Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plural items property in autocomplete data query #1047

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Jul 20, 2023

Problem

missing plural items in autocomplete data fetch

Solution

add 's'

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner July 20, 2023 23:24
@codecov-commenter
Copy link

Codecov Report

Merging #1047 (259519c) into main (ac7836a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         124      124           
  Lines        5781     5781           
  Branches     1745     1745           
=======================================
  Hits         5429     5429           
  Misses        334      334           
  Partials       18       18           
Impacted Files Coverage Δ
packages/codegen-ui-react/lib/utils/graphql.ts 94.59% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7836a...259519c. Read the comment docs.

@Jshhhh Jshhhh merged commit df2633b into main Jul 21, 2023
@Jshhhh Jshhhh deleted the autocomplete-items branch July 21, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants