Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #9061 secret migration could fail and --yes was not working #9246

Merged
merged 2 commits into from
Jan 5, 2022
Merged

fix: #9061 secret migration could fail and --yes was not working #9246

merged 2 commits into from
Jan 5, 2022

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Dec 7, 2021

Description of changes

Fix an issue when secret migration could fail when ~/.aws/amplify/deployment-secrets.json does not have an appSecrets property persisted.
Fix the --yes flag usage as exeInfo is not initialized when this prompt was executing.

Issue #, if available

Fixes #9061

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. LGTM

packages/amplify-cli/src/utils/headless-input-utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #9246 (e311318) into master (4c12eb1) will increase coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9246   +/-   ##
=======================================
  Coverage   55.36%   55.37%           
=======================================
  Files         887      887           
  Lines       50331    50349   +18     
  Branches    10869    10877    +8     
=======================================
+ Hits        27866    27880   +14     
- Misses      20393    20397    +4     
  Partials     2072     2072           
Impacted Files Coverage Δ
...ges/amplify-cli/src/utils/team-provider-migrate.ts 87.87% <ø> (ø)
...amplify-appsync-simulator/src/server/operations.ts 47.36% <25.00%> (-0.78%) ⬇️
...es/amplify-cli-core/src/deploymentSecretsHelper.ts 70.58% <66.66%> (+1.83%) ⬆️
...ages/amplify-cli/src/utils/headless-input-utils.ts 47.05% <66.66%> (+5.39%) ⬆️
packages/amplify-appsync-simulator/src/index.ts 73.52% <100.00%> (+0.26%) ⬆️
...s/amplify-appsync-simulator/src/type-definition.ts 100.00% <100.00%> (ø)
...ppsync-simulator/src/utils/auth-helpers/helpers.ts 86.20% <100.00%> (+5.25%) ⬆️
packages/amplify-cli/src/input-params-manager.ts 8.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9adbf...e311318. Read the comment docs.

@johnpc johnpc merged commit 31d07a2 into aws-amplify:master Jan 5, 2022
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jan 10, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.6 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.6.

@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.7 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Updating to Amplify CLI 7.5.0 OAuth problems
6 participants