-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #9061 secret migration could fail and --yes was not working #9246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #9246 +/- ##
=======================================
Coverage 55.36% 55.37%
=======================================
Files 887 887
Lines 50331 50349 +18
Branches 10869 10877 +8
=======================================
+ Hits 27866 27880 +14
- Misses 20393 20397 +4
Partials 2072 2072
Continue to review full report at Codecov.
|
👋 Hi, this pull request was referenced in the v7.6.6 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.6. |
👋 Hi, this pull request was referenced in the v7.6.7 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.7. |
Description of changes
Fix an issue when secret migration could fail when
~/.aws/amplify/deployment-secrets.json
does not have anappSecrets
property persisted.Fix the
--yes
flag usage asexeInfo
is not initialized when this prompt was executing.Issue #, if available
Fixes #9061
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.