Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure FF on stack transform, revert revert #8810

Merged
merged 6 commits into from
Nov 12, 2021

Conversation

jhockett
Copy link
Contributor

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner November 11, 2021 18:57
@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request introduces 2 alerts and fixes 8 when merging 3323a7f into 91443cb - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 8 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request introduces 2 alerts and fixes 8 when merging 4de198d into 24eb12a - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 8 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request fixes 8 alerts when merging 1b19b25 into d736421 - view on LGTM.com

fixed alerts:

  • 8 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request introduces 1 alert and fixes 11 when merging 3be7fb7 into 83fe16c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 11 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2021

This pull request introduces 1 alert and fixes 12 when merging 238795e into 84b3d57 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 12 for Unused variable, import, function or class

@ammarkarachi ammarkarachi changed the base branch from extOverrides5 to master November 12, 2021 01:07
@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2021

This pull request introduces 21 alerts and fixes 11 when merging 238795e into 59a7325 - view on LGTM.com

new alerts:

  • 20 for Unused variable, import, function or class
  • 1 for Useless conditional

fixed alerts:

  • 5 for Unused variable, import, function or class
  • 3 for Useless conditional
  • 1 for Implicit operand conversion
  • 1 for Useless assignment to local variable
  • 1 for Self assignment

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2021

This pull request introduces 1 alert and fixes 12 when merging e440bc9 into 257a157 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 12 for Unused variable, import, function or class

@ammarkarachi ammarkarachi merged commit 868952f into aws-amplify:master Nov 12, 2021
@jhockett jhockett deleted the ff-flag-fix branch November 12, 2021 06:44
@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2021

This pull request introduces 1 alert and fixes 12 when merging ad4cd4e into 257a157 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 12 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants