fix: schema migrator utility #8720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
changed the title
|
This pull request introduces 1 alert when merging 1f65b1c into 81cc461 - view on LGTM.com new alerts:
|
cjihrig
reviewed
Nov 8, 2021
edwardfoyle
force-pushed
the
migrator-refactor
branch
from
ad5928b
to
0b6c4fd
Compare
cjihrig
approved these changes
Nov 8, 2021
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v6.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v6.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Refactor the migration tool to be behind a new command
amplify migrate apiinstead of running during the push workflow. Also fixes several bugs, most importantly that the migrator now works with schemas that are split across multiple files.This PR does NOT change the actual migration behavior, ie. schemas are still translated in the same way.
Issue #, if available
Description of how you validated changes
Manual testing at this point. Need to write some unit tests but going ahead and publishing the PR
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.