Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchable fix and migration e2e tests #8666

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Nov 4, 2021

Description of changes

Searchable migration fix and e2e test.

Description of how you validated changes

  • yarn test
  • e2e test in local

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner November 4, 2021 06:15
@codecov-commenter
Copy link

Codecov Report

Merging #8666 (249f198) into master (73793b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8666   +/-   ##
=======================================
  Coverage   56.97%   56.98%           
=======================================
  Files         741      741           
  Lines       41707    41710    +3     
  Branches     8537     8537           
=======================================
+ Hits        23764    23767    +3     
  Misses      17122    17122           
  Partials      821      821           
Impacted Files Coverage Δ
...chable-transformer/src/cdk/create-cfnParameters.ts 100.00% <ø> (ø)
...-graphql-auth-transformer/src/accesscontrol/acm.ts 84.53% <100.00%> (+0.32%) ⬆️
...l-auth-transformer/src/graphql-auth-transformer.ts 85.40% <100.00%> (+0.02%) ⬆️
...-transformer/src/graphql-searchable-transformer.ts 96.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73793b4...249f198. Read the comment docs.

@yuth yuth merged commit d5f9397 into aws-amplify:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants