Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix null check for implied owner check #8586

Merged

Conversation

SwaySway
Copy link
Contributor

@SwaySway SwaySway commented Oct 28, 2021

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SwaySway SwaySway requested a review from a team as a code owner October 28, 2021 04:39
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2021

This pull request introduces 1 alert when merging a794969 into f72e59b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov-commenter
Copy link

Codecov Report

Merging #8586 (a794969) into master (d932f7b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8586   +/-   ##
=======================================
  Coverage   57.18%   57.19%           
=======================================
  Files         724      724           
  Lines       40886    40885    -1     
  Branches     8382     8381    -1     
=======================================
+ Hits        23382    23384    +2     
  Misses      16693    16693           
+ Partials      811      808    -3     
Impacted Files Coverage Δ
...-auth-transformer/src/resolvers/mutation.create.ts 95.38% <100.00%> (+1.44%) ⬆️
...-auth-transformer/src/resolvers/mutation.update.ts 95.38% <0.00%> (+1.53%) ⬆️
...-auth-transformer/src/resolvers/mutation.delete.ts 98.27% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d932f7b...a794969. Read the comment docs.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

@SwaySway SwaySway force-pushed the gql-vnext-dev-implicitOwnerList branch from a794969 to b0eef83 Compare October 28, 2021 19:17
@SwaySway SwaySway merged commit 4a0fda8 into aws-amplify:master Oct 30, 2021
ammarkarachi pushed a commit to ammarkarachi/amplify-cli that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants