fix: reuse foreign key field in @belongsTo
transformer
#8557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Modifies the
@belongsTo
transformer to reuse the foreign key field created by the corresponding@hasMany
directive when generating the belongsTo resolvers and types. It also reuses the same field name when the corresponding relation is@hasOne
. While this is not strictly necessary, it creates a more consistent naming experience. It also means that a@hasOne
relation can be changed to a@hasMany
relation and existing relationships will be maintained.Also created an E2E test utility that wraps a bunch of common logic for spinning up test APIs. Hopefully this can be used across many tests in the future
Issue #, if available
Description of how you validated changes
Manually tested and added an E2E test
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.