Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-frontend-javascript): geo region default #8552

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

phani-srikar
Copy link
Contributor

Description of changes

The Geo resources created before CLI v6.3.1 do not have the Region CFN output. Instead, the project region is used in aws-exports file. The Geo resources created post CLI v6.3.1 however, have Region output which is used in aws-exports. This change fixes the issue #8538 where a customer upgrades the CLI version to v6.3.1 with some Geo resources already present in the project.

Issue #, if available

#8538

Description of how you validated changes

Unit testing; JS sample app

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team as a code owner October 26, 2021 03:39
@codecov-commenter
Copy link

Codecov Report

Merging #8552 (90eb7e4) into master (02894dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8552   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files         724      724           
  Lines       40845    40845           
  Branches     8360     8360           
=======================================
  Hits        23342    23342           
  Misses      16693    16693           
  Partials      810      810           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02894dc...90eb7e4. Read the comment docs.

@ammarkarachi ammarkarachi merged commit 60255ee into master Oct 26, 2021
@phani-srikar phani-srikar deleted the geo-js-frontend-region branch November 18, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants