Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth vnext validation fixes #8551

Merged

Conversation

SwaySway
Copy link
Contributor

@SwaySway SwaySway commented Oct 26, 2021

Description of changes

  • @auth validation fixes
  • unit tests against updated validations

Description of how you validated changes

  • unit test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SwaySway SwaySway requested a review from a team as a code owner October 26, 2021 01:57
@codecov-commenter
Copy link

Codecov Report

Merging #8551 (5eb6a0e) into master (8991e78) will increase coverage by 0.00%.
The diff coverage is 76.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8551   +/-   ##
=======================================
  Coverage   57.14%   57.15%           
=======================================
  Files         724      724           
  Lines       40845    40856   +11     
  Branches     8360     8364    +4     
=======================================
+ Hits        23342    23351    +9     
- Misses      16693    16695    +2     
  Partials      810      810           
Impacted Files Coverage Δ
...-graphql-auth-transformer/src/accesscontrol/acm.ts 84.21% <62.50%> (-0.24%) ⬇️
...-graphql-auth-transformer/src/utils/validations.ts 86.00% <85.71%> (-0.37%) ⬇️
...l-auth-transformer/src/graphql-auth-transformer.ts 86.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8991e78...5eb6a0e. Read the comment docs.

@ammarkarachi ammarkarachi merged commit 2cfe6ce into aws-amplify:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants