fix: handle legacy string permissions #7305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ammarkarachi
approved these changes
May 11, 2021
4 tasks
attilah
reviewed
May 11, 2021
packages/amplify-provider-awscloudformation/src/utils/consolidate-apigw-policies.ts
Outdated
Show resolved
Hide resolved
attilah
reviewed
May 11, 2021
packages/amplify-provider-awscloudformation/src/utils/consolidate-apigw-policies.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #7305 +/- ##
==========================================
- Coverage 52.30% 52.26% -0.04%
==========================================
Files 498 498
Lines 25493 25510 +17
Branches 4995 5000 +5
==========================================
+ Hits 13333 13334 +1
- Misses 11206 11222 +16
Partials 954 954
Continue to review full report at Codecov.
|
attilah
approved these changes
May 11, 2021
|
👋 Hi, this pull request was referenced in the v4.51.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0. |
github-actions
bot
added
the
referenced-in-release
cjihrig
added a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit updates the REST API policy generation to handle legacy
'r'and'rw'values.Issue #, if available
#7301
#7310
Description of how you validated changes
Manual testing
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.