feat: prep work for SMS Sandbox support #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
May 11, 2021
attilah
suggested changes
May 11, 2021
...amplify-category-auth/src/provider-utils/awscloudformation/utils/auth-sms-workflow-helper.ts
Outdated
Show resolved
Hide resolved
...amplify-category-auth/src/provider-utils/awscloudformation/utils/auth-sms-workflow-helper.ts
Outdated
Show resolved
Hide resolved
| conditions: { | ||
| enabled: true, | ||
| cliVersions: '4.41', | ||
| startTime: new Date(Date.now() - ONE_DAY).toISOString(), |
There was a problem hiding this comment.
why do we use dynamic date for fact data instead of mocking the "current date" for the expect part in the test?
packages/amplify-cli-core/src/__tests__/banner-message/index.test.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/display-helpful-urls.js
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/display-helpful-urls.js
Outdated
Show resolved
Hide resolved
|
This pull request introduces 2 alerts when merging d2788a6 into 78854eb - view on LGTM.com new alerts:
|
attilah
reviewed
May 12, 2021
attilah
approved these changes
May 12, 2021
|
👋 Hi, this pull request was referenced in the v4.51.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0. |
github-actions
bot
added
the
referenced-in-release
SwaySway
pushed a commit
that referenced
this pull request
May 21, 2021
* feat: add support for banner message * chore: add check for SMS sandbox status * chore: address review comments * chore: fix test * chore: fix lgtm error * chore: change env var name
cjihrig
pushed a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
* feat: add support for banner message * chore: add check for SMS sandbox status * chore: address review comments * chore: fix test * chore: fix lgtm error * chore: change env var name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
SNS is going to launch SMS Sandbox experience soon. This is prep work on CLI to show a warning to customers when SMS sandbox support is released
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.