Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate prod and dev lambda function builds #6494

Merged
merged 12 commits into from
Feb 12, 2021

Conversation

edwardfoyle
Copy link
Contributor

Issue #, if available:
#5103, #4727

Description of changes:
Still need to update some tests and write tests but this PR lays the groundwork for distinguishing between "prod" and "dev" lambda function builds.

Refactored all function build / packaging logic to be in the function category plugin

Added a bunch of type definitions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle changed the title Dev build time feat: Separate prod and dev lambda function builds Jan 27, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 27, 2021

This pull request introduces 1 alert and fixes 3 when merging c8a3c55 into 525deb6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 3 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #6494 (6fccfb7) into master (31eb8eb) will decrease coverage by 0.20%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6494      +/-   ##
==========================================
- Coverage   56.96%   56.75%   -0.21%     
==========================================
  Files         484      486       +2     
  Lines       21915    22068     +153     
  Branches     4377     4412      +35     
==========================================
+ Hits        12484    12525      +41     
- Misses       8550     8662     +112     
  Partials      881      881              
Impacted Files Coverage Δ
packages/amplify-cli-core/src/index.ts 95.00% <ø> (ø)
packages/amplify-cli/src/context-extensions.ts 31.29% <0.00%> (ø)
packages/amplify-cli/src/domain/amplify-toolkit.ts 2.94% <ø> (+0.02%) ⬆️
...lify-nodejs-function-runtime-provider/src/index.ts 0.00% <0.00%> (ø)
...nction-runtime-provider/src/utils/legacyPackage.ts 0.00% <0.00%> (ø)
.../extensions/amplify-helpers/update-amplify-meta.ts 16.00% <77.77%> (ø)
packages/amplify-util-mock/src/func/index.ts 89.06% <84.21%> (+8.67%) ⬆️
...function-runtime-provider/src/utils/legacyBuild.ts 37.50% <100.00%> (ø)
...xtensions/amplify-helpers/update-backend-config.ts 26.31% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31eb8eb...6fccfb7. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2021

This pull request introduces 1 alert and fixes 3 when merging d3a5f88 into 357f787 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 3 for Unused variable, import, function or class

@edwardfoyle edwardfoyle marked this pull request as ready for review January 29, 2021 19:15
@edwardfoyle edwardfoyle requested a review from a team as a code owner January 29, 2021 19:15
@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2021

This pull request fixes 3 alerts when merging 2919201 into d2bc6d8 - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@edwardfoyle edwardfoyle force-pushed the dev-build-time branch 2 times, most recently from e106da1 to 5d03437 Compare February 2, 2021 00:34
@lgtm-com
Copy link

lgtm-com bot commented Feb 2, 2021

This pull request fixes 3 alerts when merging cd12d88 into 1e115c5 - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Feb 5, 2021

This pull request fixes 3 alerts when merging c018f97 into 8647486 - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 10, 2021

This pull request fixes 3 alerts when merging 34846a7 into b866ccc - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 3 alerts when merging e0b0f3b into 31eb8eb - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 3 alerts when merging 6fccfb7 into 31eb8eb - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants