-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Separate prod and dev lambda function builds #6494
Conversation
This pull request introduces 1 alert and fixes 3 when merging c8a3c55 into 525deb6 - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #6494 +/- ##
==========================================
- Coverage 56.96% 56.75% -0.21%
==========================================
Files 484 486 +2
Lines 21915 22068 +153
Branches 4377 4412 +35
==========================================
+ Hits 12484 12525 +41
- Misses 8550 8662 +112
Partials 881 881
Continue to review full report at Codecov.
|
This pull request introduces 1 alert and fixes 3 when merging d3a5f88 into 357f787 - view on LGTM.com new alerts:
fixed alerts:
|
packages/amplify-category-function/src/commands/function/build.ts
Outdated
Show resolved
Hide resolved
...ages/amplify-category-function/src/provider-utils/awscloudformation/utils/packageFunction.ts
Show resolved
Hide resolved
packages/amplify-category-function/src/provider-utils/awscloudformation/utils/packageLayer.ts
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/copy-batch.ts
Outdated
Show resolved
Hide resolved
This pull request fixes 3 alerts when merging 2919201 into d2bc6d8 - view on LGTM.com fixed alerts:
|
e106da1
to
5d03437
Compare
This pull request fixes 3 alerts when merging cd12d88 into 1e115c5 - view on LGTM.com fixed alerts:
|
...ages/amplify-category-function/src/provider-utils/awscloudformation/utils/packageFunction.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request fixes 3 alerts when merging c018f97 into 8647486 - view on LGTM.com fixed alerts:
|
This pull request fixes 3 alerts when merging 34846a7 into b866ccc - view on LGTM.com fixed alerts:
|
34846a7
to
e0b0f3b
Compare
This pull request fixes 3 alerts when merging e0b0f3b into 31eb8eb - view on LGTM.com fixed alerts:
|
e0b0f3b
to
feb5ff0
Compare
This pull request fixes 3 alerts when merging 6fccfb7 into 31eb8eb - view on LGTM.com fixed alerts:
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#5103, #4727
Description of changes:
Still need to update some tests and write tests but this PR lays the groundwork for distinguishing between "prod" and "dev" lambda function builds.
Refactored all function build / packaging logic to be in the function category plugin
Added a bunch of type definitions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.