-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimize mock package imports #6455
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6455 +/- ##
==========================================
- Coverage 57.30% 57.25% -0.06%
==========================================
Files 474 479 +5
Lines 21669 21689 +20
Branches 4306 4310 +4
==========================================
Hits 12418 12418
- Misses 8370 8390 +20
Partials 881 881
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging 0bc9605 into 0530d1a - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of minor nits
This pull request fixes 1 alert when merging 4f2384c into 75f5ace - view on LGTM.com fixed alerts:
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#5103
Description of changes:
There were some circular imports when importing the mock package causing the import of that package to take ~5 seconds. This PR fixes these circular imports as well as migrates the command .js files to .ts files
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.