Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resource Tagging Support #5178

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Conversation

ammarkarachi
Copy link
Contributor

Enable to customers to add tags using /amplify/backend/tags.json file

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Enable to customers to add tags using `/amplify/backend/tags.json` file
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #5178 into master will increase coverage by 0.00%.
The diff coverage is 62.96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5178   +/-   ##
=======================================
  Coverage   61.39%   61.39%           
=======================================
  Files         378      380    +2     
  Lines       16703    16730   +27     
  Branches     3124     3127    +3     
=======================================
+ Hits        10255    10272   +17     
- Misses       5956     5966   +10     
  Partials      492      492           
Impacted Files Coverage Δ
packages/amplify-cli/src/domain/amplify-toolkit.ts 1.56% <0.00%> (-0.02%) ⬇️
.../amplify-cli-core/src/state-manager/pathManager.ts 42.18% <50.00%> (+0.52%) ⬆️
...amplify-cli-core/src/state-manager/stateManager.ts 40.84% <66.66%> (+2.38%) ⬆️
packages/amplify-cli-core/src/tags/Tags.ts 69.23% <69.23%> (ø)
packages/amplify-cli-core/src/index.ts 100.00% <100.00%> (ø)
packages/amplify-cli-core/src/tags/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3212e13...758889f. Read the comment docs.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ammarkarachi ammarkarachi merged commit e34226d into aws-amplify:master Aug 27, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants