Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on unmaintained node-ip package from amplify-appsync-simulator #13890

Closed
2 tasks done
jwilson-anonyome opened this issue Aug 11, 2024 · 2 comments
Closed
2 tasks done
Labels
pending-triage Issue is pending triage

Comments

@jwilson-anonyome
Copy link
Contributor

How did you install the Amplify CLI?

yarn

If applicable, what version of Node.js are you using?

v20.16.0

Amplify CLI Version

2.16.4

What operating system are you using?

Mac

Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.

No manual changes

Describe the bug

amplify-appsync-simulator uses the node-ip package to get the local IP address, where the simulator may be running.

The node-ip project is abandoned. It has a reported security vulnerability.

Expected behavior

Build and run code using amplify-appsync-simulator without encountering failures or warnings due to security vulnerabilities.

Reproduction steps

yarn audit

Project Identifier

No response

Log output

# Put your logs below this line


Additional information

PR to remove the dependency in #13877

Before submitting, please confirm:

  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
  • I have removed any sensitive information from my code snippets and submission.
@jwilson-anonyome jwilson-anonyome added the pending-triage Issue is pending triage label Aug 11, 2024
@ykethan
Copy link
Member

ykethan commented Aug 13, 2024

closing this as #13877 has been merged.

@ykethan ykethan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-triage Issue is pending triage
Projects
None yet
Development

No branches or pull requests

2 participants