Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't create symlinks after extracting zip #13791

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

Amplifiyer
Copy link
Contributor

Description of changes

fix: don't create symlinks after extracting zip

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Amplifiyer Amplifiyer requested a review from a team as a code owner May 22, 2024 20:21
edwardfoyle
edwardfoyle previously approved these changes May 22, 2024
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments but I don't think they are functional blockers. Should this PR be based off of hotfix instead of dev?

sobolk
sobolk previously approved these changes May 22, 2024
packages/amplify-cli-core/src/extractZip.js Show resolved Hide resolved
@Amplifiyer Amplifiyer dismissed stale reviews from sobolk and edwardfoyle via 8eb6dae May 22, 2024 21:14
@Amplifiyer Amplifiyer force-pushed the run-e2e/Amplifiyer/extractZip branch from b34562e to 8eb6dae Compare May 22, 2024 21:14
@Amplifiyer
Copy link
Contributor Author

couple comments but I don't think they are functional blockers. Should this PR be based off of hotfix instead of dev?

We only have d583756 in the dev that is a functional change. I think we can use regular release for this.

@0618 0618 merged commit 08f358d into dev May 22, 2024
5 checks passed
@0618 0618 deleted the run-e2e/Amplifiyer/extractZip branch May 22, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants