Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing arn with multiple slashes when importing auth #13009

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

jhockett
Copy link
Contributor

Description of changes

Allow more than 1 forward slash in role arns for authenticated and unauthenticated roles when importing auth

This PR is nearly a duplicate of #12987, but it targets the hotfix branch.

Issue #, if available

Fixes #12817

Description of how you validated changes

Manually imported auth (Cognito User Pool and Identity Pool) with multiple slashes in the IAM role names for auth and unauth. Created test web app to confirm account creation and sign-in/sign-out.

These steps fail with 12.2.0 CLI, but succeed with PR changes.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner July 26, 2023 15:57
Copy link
Contributor

@awsluja awsluja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ passing e2e

@jhockett jhockett merged commit 455c514 into aws-amplify:hotfix Jul 26, 2023
5 checks passed
@jhockett jhockett deleted the fix-arn-parsing-hf branch July 26, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants