Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cycle detection in yarn 1 and npm detector #12255

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Mar 17, 2023

Description of changes

This fixes yarn 1 and npm dfs algorithm to handle cycles.

Fixes #12244

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner March 17, 2023 01:07
@codecov-commenter
Copy link

Codecov Report

Merging #12255 (59241bf) into dev (984c0f8) will decrease coverage by 2.36%.
The diff coverage is 55.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev   #12255      +/-   ##
==========================================
- Coverage   49.45%   47.09%   -2.36%     
==========================================
  Files         692      836     +144     
  Lines       33424    38036    +4612     
  Branches     6840     7714     +874     
==========================================
+ Hits        16529    17914    +1385     
- Misses      15370    18484    +3114     
- Partials     1525     1638     +113     
Impacted Files Coverage Δ
...mplify-appsync-simulator/src/resolvers/function.ts 15.38% <ø> (ø)
...s/amplify-appsync-simulator/src/type-definition.ts 100.00% <ø> (ø)
...sync-simulator/src/velocity/util/dynamodb-utils.ts 6.55% <0.00%> (ø)
...y-appsync-simulator/src/velocity/util/map-utils.ts 10.00% <ø> (ø)
...tor/src/velocity/util/transform/dynamodb-filter.ts 4.93% <0.00%> (ø)
...appsync-simulator/src/velocity/value-mapper/map.ts 86.88% <ø> (ø)
...ackages/amplify-category-auth/src/commands/auth.ts 0.00% <0.00%> (ø)
...es/amplify-category-auth/src/commands/auth/help.ts 0.00% <0.00%> (ø)
.../amplify-category-auth/src/commands/auth/import.ts 0.00% <0.00%> (ø)
...dformation/auth-inputs-manager/auth-input-state.ts 46.93% <0.00%> (ø)
... and 101 more

... and 458 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sobolk sobolk merged commit aa07944 into aws-amplify:dev Mar 17, 2023
@sobolk sobolk deleted the fix-dfs branch March 17, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants