Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depend on inquirer in amplify-cli-core #12087

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

sdstolworthy
Copy link
Contributor

Description of changes

Adds a dependency on inquirer@^7.3.3 in amplify-cli-core.

Description of how you validated changes

Built an application that leverages AmplifyHelpers.addResourceDependency using a version of @aws-amplify/cli-extensibility-helper on local dev that depended on the patched amplify-cli-core.

image

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sdstolworthy sdstolworthy requested a review from a team as a code owner February 23, 2023 04:41
yarn.lock Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #12087 (bb2cc4b) into dev (984c0f8) will decrease coverage by 3.31%.
The diff coverage is 53.78%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev   #12087      +/-   ##
==========================================
- Coverage   49.45%   46.14%   -3.31%     
==========================================
  Files         692      820     +128     
  Lines       33424    37575    +4151     
  Branches     6840     7641     +801     
==========================================
+ Hits        16529    17339     +810     
- Misses      15370    18560    +3190     
- Partials     1525     1676     +151     
Impacted Files Coverage Δ
...sync-simulator/src/data-loader/opensearch/index.ts 45.45% <0.00%> (ø)
...s/amplify-appsync-simulator/src/type-definition.ts 100.00% <ø> (ø)
...sync-simulator/src/velocity/util/dynamodb-utils.ts 6.55% <0.00%> (ø)
...y-appsync-simulator/src/velocity/util/map-utils.ts 10.00% <ø> (ø)
...tor/src/velocity/util/transform/dynamodb-filter.ts 4.93% <0.00%> (ø)
...ync-simulator/src/velocity/util/transform/index.ts 21.05% <0.00%> (ø)
...appsync-simulator/src/velocity/value-mapper/map.ts 86.88% <ø> (ø)
...ackages/amplify-category-auth/src/commands/auth.ts 0.00% <0.00%> (ø)
...es/amplify-category-auth/src/commands/auth/help.ts 0.00% <0.00%> (ø)
.../amplify-category-auth/src/commands/auth/import.ts 0.00% <0.00%> (ø)
... and 536 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edwardfoyle edwardfoyle merged commit 546f15c into aws-amplify:dev Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants