-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding cli options commands hooks #11898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshbhu
added
do-not-merge
PRs that are approved and green, but should not be merged yet
and removed
do-not-merge
PRs that are approved and green, but should not be merged yet
labels
Feb 3, 2023
akshbhu
changed the title
feat: adding cli options commands hooks
[DO-NOT-MERGE]feat: adding cli options commands hooks
Feb 3, 2023
aws-eddy
added
the
do-not-merge
PRs that are approved and green, but should not be merged yet
label
Feb 3, 2023
sobolk
reviewed
Feb 3, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #11898 +/- ##
==========================================
- Coverage 49.45% 46.00% -3.45%
==========================================
Files 692 819 +127
Lines 33424 37676 +4252
Branches 6840 7736 +896
==========================================
+ Hits 16529 17333 +804
- Misses 15370 18647 +3277
- Partials 1525 1696 +171
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sobolk
approved these changes
Feb 7, 2023
akshbhu
changed the title
[DO-NOT-MERGE]feat: adding cli options commands hooks
feat: adding cli options commands hooks
Feb 13, 2023
sdstolworthy
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #11848
Description of how you validated changes
PrePush.js -> console.log('hello')
preload.js -> console.log('this is from preload')
Hooks Config:
amplify Output:
amplify-dev output :
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.