-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: manual lint fixes #11638
fix: manual lint fixes #11638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run e2e tests for this PR.
packages/amplify-appsync-simulator/src/server/subscription/websocket-server/server.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #11638 +/- ##
==========================================
- Coverage 50.20% 50.16% -0.04%
==========================================
Files 702 702
Lines 33955 33999 +44
Branches 6969 6976 +7
==========================================
+ Hits 17047 17056 +9
- Misses 15431 15463 +32
- Partials 1477 1480 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...fy-category-auth/src/provider-utils/awscloudformation/service-walkthroughs/auth-questions.ts
Show resolved
Hide resolved
packages/amplify-category-custom/src/utils/dependency-management-utils.ts
Outdated
Show resolved
Hide resolved
...s/amplify-category-function/src/provider-utils/awscloudformation/utils/convertLayersTypes.ts
Show resolved
Hide resolved
packages/amplify-e2e-tests/src/schema-api-directives/tests/predictions-usage.ts
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/configuration-manager.ts
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing comma thing seems like the only thing that should be fixed before this is merged. Other than that I'm okay with where we landed on the other comments
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
...-analytics/src/provider-utils/awscloudformation/service-walkthroughs/pinpoint-walkthrough.ts
Outdated
Show resolved
Hide resolved
...category-storage/src/provider-utils/awscloudformation/service-walkthroughs/s3-walkthrough.ts
Show resolved
Hide resolved
655e131
Description of changes
Fixes for:
Issue #, if available
Description of how you validated changes
Ran tests and verified no meaningful api changes.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.