Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manual lint fixes #11638

Merged
merged 32 commits into from
Dec 27, 2022
Merged

Conversation

sdstolworthy
Copy link
Contributor

@sdstolworthy sdstolworthy commented Dec 21, 2022

Description of changes

Fixes for:

  • no-constant-condition
  • no-useless-catch
  • @typescript-eslint/ban-ts-comment
  • no-async-promise-executor
  • no-empty
  • jest/no-standalone-expect
  • no-prototype-builtins
  • prefer-const
  • jest/no-conditional-expect
  • no-useless-escape
  • @typescript-eslint/no-empty-function
  • no-case-declarations
  • consistent-return
  • double negation

Issue #, if available

Description of how you validated changes

Ran tests and verified no meaningful api changes.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sdstolworthy sdstolworthy marked this pull request as ready for review December 21, 2022 17:56
@sdstolworthy sdstolworthy requested a review from a team as a code owner December 21, 2022 17:56
sobolk
sobolk previously approved these changes Dec 21, 2022
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run e2e tests for this PR.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #11638 (b272738) into dev (0e7f70b) will decrease coverage by 0.03%.
The diff coverage is 34.32%.

@@            Coverage Diff             @@
##              dev   #11638      +/-   ##
==========================================
- Coverage   50.20%   50.16%   -0.04%     
==========================================
  Files         702      702              
  Lines       33955    33999      +44     
  Branches     6969     6976       +7     
==========================================
+ Hits        17047    17056       +9     
- Misses      15431    15463      +32     
- Partials     1477     1480       +3     
Impacted Files Coverage Δ
...y-appsync-simulator/src/resolvers/unit-resolver.ts 90.32% <0.00%> (ø)
...c-simulator/src/schema/directives/aws-subscribe.ts 96.42% <0.00%> (-3.58%) ⬇️
...ages/amplify-appsync-simulator/src/schema/index.ts 70.68% <0.00%> (-1.25%) ⬇️
...tor/src/velocity/util/transform/dynamodb-filter.ts 4.93% <0.00%> (ø)
...c/provider-utils/awscloudformation/import/index.ts 31.02% <ø> (ø)
...ges/amplify-category-custom/src/commands/custom.ts 0.00% <0.00%> (ø)
...tion/src/provider-utils/awscloudformation/index.ts 12.87% <0.00%> (-0.06%) ⬇️
...ion/service-walkthroughs/lambdaLayerWalkthrough.ts 11.21% <0.00%> (ø)
...rc/provider-utils/awscloudformation/utils/build.ts 57.14% <0.00%> (ø)
...r-utils/awscloudformation/utils/funcParamsUtils.ts 23.52% <0.00%> (-1.48%) ⬇️
... and 64 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

edwardfoyle
edwardfoyle previously approved these changes Dec 21, 2022
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing comma thing seems like the only thing that should be fixed before this is merged. Other than that I'm okay with where we landed on the other comments

sobolk
sobolk previously approved these changes Dec 21, 2022
edwardfoyle
edwardfoyle previously approved these changes Dec 21, 2022
@sdstolworthy sdstolworthy merged commit 2294cf8 into aws-amplify:dev Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants