fix: async persist env params on success #11367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
commented
Nov 10, 2022
| @@ -36,7 +36,7 @@ describe('amplify status:', () => { | |||
| const { run } = require('../../commands/status'); | |||
| const runStatusCmd = run; | |||
| const statusPluginInfo = `${process.cwd()}/../amplify-console-hosting`; | |||
| const mockPath = './'; | |||
| const mockPath = './help'; | |||
There was a problem hiding this comment.
Not 100% sure why the test updates in this file were necessary
jhockett
previously approved these changes
Nov 10, 2022
sobolk
reviewed
Nov 10, 2022
| @@ -78,7 +86,7 @@ class EnvironmentParameterManager implements IEnvironmentParameterManager { | |||
| return !!this.resourceParamManagers[getResourceKey(category, resource)]; | |||
| } | |||
|
|
|||
| save(): void { | |||
| async save(): Promise<void> { | |||
There was a problem hiding this comment.
it can be synchronous for now, but we are getting ready to add some async stuff
sobolk
reviewed
Nov 10, 2022
packages/amplify-environment-parameters/src/environment-parameter-manager.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kamil Sobol <[email protected]>
sobolk
approved these changes
Nov 11, 2022
jhockett
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes the save on exit listener from environment parameter managers and instead exposes a
saveAllmethod that is called at the end of the CLI command execution to persist any mutated parameters.This ensures that parameters are only persisted if the command succeeded and also allows us to perform async operations during the save.
Issue #, if available
Description of how you validated changes
manually verified and updated unit tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.