Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Turn the auto-populate owner field FF ON for new projects #11230

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented Oct 20, 2022

Description of changes

Turns the Feature Flag populateOwnerFieldForStaticGroupAuth to true by default for the new customers of Amplify CLI. This is non-breaking as we retain the previous behavior for existing customers.
Link to docs PR: aws-amplify/docs#4733

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team as a code owner October 20, 2022 17:08
@alharris-at
Copy link
Contributor

Are there docs updates required here as well?

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link a docs PR to add populateOwnerFieldForStaticGroupAuth to this page: https://docs.amplify.aws/cli/reference/feature-flags/

@phani-srikar
Copy link
Contributor Author

Added link to docs PR: aws-amplify/docs#4733

@aws-eddy aws-eddy merged commit 0e69509 into dev Oct 24, 2022
@aws-eddy aws-eddy deleted the guest/edupp/populateOwnerFieldFF branch October 24, 2022 16:42
akshbhu added a commit that referenced this pull request Oct 27, 2022
* feat: converts auth and storage categories to cdk V2

* fix: fixes auth unit test

* fix: minor fixes in categories

* fix: increase node memory usage

* fix: removes invalid import

* fix: fixes custom resource test

* chore: turn the auto-populate owner field FF ON for new projects (#11230)

* fix: converts all categories to v2

* chore: added linting

* fix: fixes unit tests

* chore: address comments

* chore: fixes ordring in package.json

* chore: minor fixes

* chore: reverts unused imports and merge changes

Co-authored-by: Akshay Upadhyay <[email protected]>
Co-authored-by: Phani Srikar Edupuganti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants