Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserPool not being tagged properly from tags.json #11069

Closed
5 tasks done
nathanthorpe opened this issue Sep 26, 2022 · 2 comments · May be fixed by olivialancaster/amplify-cli#363, olivialancaster/amplify-cli#364 or olivialancaster/amplify-cli#376
Labels
auth Issues tied to the auth category of the CLI bug Something isn't working duplicate If marked with duplicate, issue will be closed & original will be added for traceability platform Issues tied to the general CLI platform

Comments

@nathanthorpe
Copy link

Before opening, please confirm:

  • I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
  • I have searched for duplicate or closed issues.
  • I have read the guide for submitting bug reports.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
  • I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?

npm

If applicable, what version of Node.js are you using?

v16.17.0

Amplify CLI Version

10.0.0

What operating system are you using?

Windows

Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.

No manual changes made

Amplify Categories

auth

Amplify Commands

Not applicable

Describe the bug

The user pool is not being tagged by the tags.json file.

Tags.json file:

[
  {
    "Key": "application",
    "Value": "{project-name}-infra"
  },
  {
    "Key": "environment",
    "Value": "{project-env}"
  },
  {
    "Key": "createdby",
    "Value": "Amplify"
  },
  {
    "Key": "owner",
    "Value": "Amplify"
  }
]

User pool:
image

Expected behavior

It should be tagged like the other resources

Reproduction steps

  • Add auth
  • Push
  • Observe no tags being added to user pool

GraphQL schema(s)

Not Applicable

Project Identifier

No response

Log output

Not applicable

Additional information

Currently to get around it, in the override.ts I've been adding the following:

 resources.userPool.tags.setTag(
    'application', `${config.applicationName}-infra`
  );
  resources.userPool.tags.setTag(
    'environment', config.env
  );
  resources.userPool.tags.setTag(
    'createdby', 'Amplify'
  );
@josefaidt
Copy link
Contributor

Hey @nathanthorpe 👋 thanks for raising this and for providing the workaround! It appears this is a duplicate of aws-amplify/amplify-studio#743 and more specifically, #6642. Closing in favor of tracking the existing items

@josefaidt josefaidt closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
@josefaidt josefaidt added bug Something isn't working auth Issues tied to the auth category of the CLI platform Issues tied to the general CLI platform duplicate If marked with duplicate, issue will be closed & original will be added for traceability labels Sep 28, 2022
@nathanthorpe
Copy link
Author

Ah great thanks, my bad I searched User pool rather than cognito 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Issues tied to the auth category of the CLI bug Something isn't working duplicate If marked with duplicate, issue will be closed & original will be added for traceability platform Issues tied to the general CLI platform
Projects
None yet
2 participants