feat: move oauth secrets to parameter store #10413

akshbhu · 2022-05-13T02:26:04Z

Description of changes

Moved OAuth secrets to parameter store
Added tests
changed hostedUI lambda to fetch secrets from parameter store

Description of how you validated changes

added e2es
manually tested

Checklist

PR description included
yarn test passes
Tests are changed or added
Relevant documentation is changed or added (and PR referenced)
New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lgtm-com · 2022-05-13T02:38:03Z

This pull request introduces 7 alerts when merging 91c26ee into 59c6422 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class
3 for Useless assignment to local variable

.vscode/settings.json

...category-auth/src/provider-utils/awscloudformation/auth-secret-manager/sync-oauth-secrets.ts

...y-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.ts

...ategory-auth/src/provider-utils/awscloudformation/auth-secret-manager/auth-secret-manager.ts

lgtm-com · 2022-05-16T10:56:22Z

This pull request introduces 8 alerts when merging 7abb7e9 into 355c477 - view on LGTM.com

new alerts:

5 for Unused variable, import, function or class
3 for Useless assignment to local variable

lgtm-com · 2022-05-16T15:55:59Z

This pull request introduces 8 alerts when merging 162f4e5 into 355c477 - view on LGTM.com

new alerts:

5 for Unused variable, import, function or class
3 for Useless assignment to local variable

packages/amplify-category-auth/src/__tests__/commands/import.headless.test.ts

...mplify-category-auth/src/provider-utils/awscloudformation/auth-secret-manager/secret-name.ts

...category-auth/src/provider-utils/awscloudformation/auth-secret-manager/sync-oauth-secrets.ts

.../amplify-category-auth/src/provider-utils/awscloudformation/auth-secret-manager/tpi-utils.ts

...ategory-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-stack-transform.ts

...ges/amplify-category-auth/src/provider-utils/awscloudformation/handlers/resource-handlers.ts

...ify-category-auth/src/provider-utils/awscloudformation/utils/generate-auth-stack-template.ts

packages/amplify-provider-awscloudformation/src/resourceParams.js

packages/amplify-migration-tests/src/__tests__/update_tests/auth_migration_update.test.ts

lgtm-com · 2022-05-16T21:00:33Z

This pull request introduces 6 alerts when merging 60276d1 into d43a009 - view on LGTM.com

new alerts:

3 for Useless assignment to local variable
3 for Unused variable, import, function or class

packages/amplify-category-auth/resources/auth-custom-resource/hostedUIProviderLambda.js

...ategory-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-stack-transform.ts

...y-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.ts

...y-category-auth/src/provider-utils/awscloudformation/utils/get-oauth-secrets-from-cognito.ts

packages/amplify-dynamodb-simulator/__test__/index.test.js

packages/amplify-e2e-core/src/categories/auth.ts

lgtm-com · 2022-05-16T22:31:19Z

This pull request introduces 6 alerts when merging 24e2ca6 into 269bb56 - view on LGTM.com

new alerts:

3 for Useless assignment to local variable
3 for Unused variable, import, function or class

lgtm-com · 2022-05-16T23:30:26Z

This pull request introduces 4 alerts when merging a7fb694 into 10d8468 - view on LGTM.com

new alerts:

3 for Unused variable, import, function or class
1 for Syntax error

lgtm-com · 2022-05-17T01:29:38Z

This pull request introduces 8 alerts when merging 3353521 into cba70d6 - view on LGTM.com

new alerts:

3 for Useless assignment to local variable
3 for Unused variable, import, function or class
2 for Assignment to constant

lgtm-com · 2022-05-17T10:56:33Z

This pull request introduces 9 alerts when merging f11a595 into cba70d6 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class
3 for Useless assignment to local variable
2 for Assignment to constant

lgtm-com · 2022-05-18T19:52:54Z

This pull request introduces 10 alerts when merging a177f74 into 1b789bf - view on LGTM.com

new alerts:

5 for Unused variable, import, function or class
3 for Useless assignment to local variable
2 for Assignment to constant

edwardfoyle · 2022-05-18T22:11:07Z

...ategory-auth/src/provider-utils/awscloudformation/auth-secret-manager/auth-secret-manager.ts

+      await this.ssmClient
+        .getParameter({
+          Name: secretName,
+          WithDecryption: true,


this can be false in this case

edwardfoyle · 2022-05-18T22:11:53Z

...ategory-auth/src/provider-utils/awscloudformation/auth-secret-manager/auth-secret-manager.ts

+          WithDecryption: true,
+        })
+        .promise();
+    } catch (err) {


to be completely accurate we should check that the error was a "not exists" exception rather than something else

lgtm-com · 2022-05-19T09:37:39Z

This pull request introduces 12 alerts when merging 5d0d670 into d9bdcd8 - view on LGTM.com

new alerts:

7 for Unused variable, import, function or class
3 for Useless assignment to local variable
2 for Assignment to constant

lgtm-com · 2022-05-19T10:07:29Z

This pull request introduces 12 alerts when merging 603977f into d9bdcd8 - view on LGTM.com

new alerts:

7 for Unused variable, import, function or class
3 for Useless assignment to local variable
2 for Assignment to constant

...ategory-auth/src/provider-utils/awscloudformation/auth-secret-manager/auth-secret-manager.ts

...category-auth/src/provider-utils/awscloudformation/auth-secret-manager/sync-oauth-secrets.ts

...y-category-auth/src/provider-utils/awscloudformation/utils/get-oauth-secrets-from-cognito.ts

This reverts commit 16db2ce.

akshbhu requested a review from a team as a code owner May 13, 2022 02:26

edwardfoyle reviewed May 13, 2022

View reviewed changes

akshbhu force-pushed the secrets_remove2 branch from 91c26ee to 35c41de Compare May 16, 2022 10:34

akshbhu changed the title ~~Secrets remove2~~ fix: move oauth secrets to parameter store May 16, 2022

jhockett reviewed May 16, 2022

View reviewed changes

akshbhu force-pushed the secrets_remove2 branch from 162f4e5 to 60276d1 Compare May 16, 2022 20:42

edwardfoyle reviewed May 16, 2022

View reviewed changes

akshbhu force-pushed the secrets_remove2 branch from 3353521 to f11a595 Compare May 17, 2022 10:44

edwardfoyle approved these changes May 18, 2022

View reviewed changes

akshbhu added 12 commits May 19, 2022 02:03

fix: moves secret to cloud and fixes existing e2e

2016038

fix: lint fixes

e13dcde

fix: added tests

ae86b01

chore: remove local files

790fbb5

chore: fixes build

c508c2d

fix: address PR comments

1c55f3f

chore: removed comments

326051a

fix: updated lambda code

5950554

fix: fixes unit tests

eb55409

fix: migrates before ext projects

bba1810

fix: migrates older projects

5310e1b

fix: added get secret calls

edb8099

fix: remove oauth secrets

5d0d670

akshbhu force-pushed the secrets_remove2 branch from a177f74 to 5d0d670 Compare May 19, 2022 09:26

chore: fixes build

603977f

jhockett changed the title ~~fix: move oauth secrets to parameter store~~ feat: move oauth secrets to parameter store May 19, 2022

akshbhu added 2 commits May 19, 2022 13:02

fix: remove auth tests

77d12cc

fix: envParams unit test

788e063

jhockett reviewed May 19, 2022

View reviewed changes

jhockett approved these changes May 19, 2022

View reviewed changes

chore: fix styling in comments

f0bd012

jhockett merged commit 16db2ce into aws-amplify:master May 19, 2022

edwardfoyle added a commit to edwardfoyle/amplify-cli that referenced this pull request May 27, 2022

Revert "feat: move oauth secrets to parameter store (aws-amplify#10413)"

68c3bd8

This reverts commit 16db2ce.

edwardfoyle added a commit to edwardfoyle/amplify-cli that referenced this pull request May 27, 2022

Revert "feat: move oauth secrets to parameter store (aws-amplify#10413)"

c7c4b26

This reverts commit 16db2ce.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: move oauth secrets to parameter store #10413

feat: move oauth secrets to parameter store #10413

akshbhu commented May 13, 2022 •

edited

Loading

lgtm-com bot commented May 13, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 17, 2022

lgtm-com bot commented May 17, 2022

lgtm-com bot commented May 18, 2022

edwardfoyle May 18, 2022

edwardfoyle May 18, 2022

lgtm-com bot commented May 19, 2022

lgtm-com bot commented May 19, 2022

feat: move oauth secrets to parameter store #10413

feat: move oauth secrets to parameter store #10413

Conversation

akshbhu commented May 13, 2022 • edited Loading

Description of changes

Description of how you validated changes

Checklist

lgtm-com bot commented May 13, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 16, 2022

lgtm-com bot commented May 17, 2022

lgtm-com bot commented May 17, 2022

lgtm-com bot commented May 18, 2022

edwardfoyle May 18, 2022

Choose a reason for hiding this comment

edwardfoyle May 18, 2022

Choose a reason for hiding this comment

lgtm-com bot commented May 19, 2022

lgtm-com bot commented May 19, 2022

akshbhu commented May 13, 2022 •

edited

Loading