Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: diagnose #10383

Merged
merged 25 commits into from
Jun 1, 2022
Merged

feat: diagnose #10383

merged 25 commits into from
Jun 1, 2022

Conversation

ammarkarachi
Copy link
Contributor

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammarkarachi ammarkarachi requested a review from a team as a code owner May 9, 2022 19:50
@ammarkarachi ammarkarachi changed the title Feat/poc reporter feat: diagnose May 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10383 (3612900) into master (714f2fa) will increase coverage by 0.04%.
The diff coverage is 56.04%.

@@            Coverage Diff             @@
##           master   #10383      +/-   ##
==========================================
+ Coverage   46.57%   46.61%   +0.04%     
==========================================
  Files         703      708       +5     
  Lines       35246    35488     +242     
  Branches     7134     7164      +30     
==========================================
+ Hits        16417    16544     +127     
- Misses      17042    17144     +102     
- Partials     1787     1800      +13
Impacted Files Coverage Δ
packages/amplify-cli/src/commands/status.ts 40.98% <ø> (ø)
...ify-cli/src/domain/amplify-usageData/IUsageData.ts 100.00% <ø> (ø)
...lify-cli/src/domain/amplify-usageData/UsageData.ts 77.52% <0.00%> (-12.25%) ⬇️
...ackages/amplify-cli/src/app-config/debug-config.ts 6.97% <6.97%> (ø)
.../amplify-cli/src/commands/helpers/collect-files.ts 36.36% <36.36%> (ø)
...es/amplify-cli/src/init-steps/s0-analyzeProject.ts 68.33% <40.00%> (-0.81%) ⬇️
...fy-cli/src/domain/amplify-usageData/NoUsageData.ts 13.79% <50.00%> (+5.79%) ⬆️
.../amplify-cli/src/init-steps/s8-scaffoldHeadless.ts 91.30% <50.00%> (+3.80%) ⬆️
...ackages/amplify-cli/src/init-steps/s9-onSuccess.ts 14.06% <50.00%> (+0.57%) ⬆️
packages/amplify-cli/src/index.ts 38.80% <60.00%> (+0.22%) ⬆️
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

lazpavel
lazpavel reviewed Jun 1, 2022
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
lazpavel
lazpavel approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@lazpavel lazpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, small nits

packages/amplify-e2e-core/src/index.ts
@@ -7,12 +7,13 @@ import { spawnSync, execSync } from 'child_process';
import { v4 as uuid } from 'uuid';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any actual changes in this file?

packages/amplify-e2e-core/src/init/initProjectHelper.ts Outdated Show resolved Hide resolved
packages/amplify-cli/src/app-config/debug-config.ts Outdated Show resolved Hide resolved
sachscode
sachscode reviewed Jun 1, 2022
View reviewed changes
Copy link
Contributor

@sachscode sachscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions

packages/amplify-cli/src/commands/helpers/collect-files.ts Show resolved Hide resolved
packages/amplify-cli/package.json Outdated Show resolved Hide resolved
packages/amplify-cli-logger/src/Redactor.ts Outdated Show resolved Hide resolved
sachscode
sachscode approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@sachscode sachscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lazpavel lazpavel merged commit 6a29bd9 into aws-amplify:master Jun 1, 2022
@alharris-at alharris-at mentioned this pull request Jun 3, 2022
Merged
3 tasks
@phani-srikar phani-srikar mentioned this pull request Jun 6, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhockett jhockett jhockett left review comments

@lazpavel lazpavel lazpavel approved these changes

@sachscode sachscode sachscode approved these changes

@marcvberg marcvberg Awaiting requested review from marcvberg

@phani-srikar phani-srikar Awaiting requested review from phani-srikar

@sundersc sundersc Awaiting requested review from sundersc

@alharris-at alharris-at Awaiting requested review from alharris-at

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ammarkarachi @codecov-commenter @jhockett @sachscode @lazpavel