fix: make amplify prompts dependency explicit, lint errors #10007
Conversation
|
Looks like there's a bug in the PR lint check script where it's returning a 0 exit code even when there are errors: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/7043/workflows/ed2d3288-0116-4bf9-a011-4f748c2e9151/jobs/188647/parallel-runs/0/steps/0-103 |
Codecov Report
@@ Coverage Diff @@
## master #10007 +/- ##
=======================================
Coverage 54.08% 54.08%
=======================================
Files 837 837
Lines 46340 46340
Branches 9885 9885
=======================================
Hits 25065 25065
Misses 19281 19281
Partials 1994 1994
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -219,14 +283,17 @@ export interface ProviderContext { | |||
| projectName: string; | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
There was a problem hiding this comment.
does the fixer just drop these empty blocks in?
There was a problem hiding this comment.
Yeah. I didn't comment in some places because I wasn't sure I understood the full context
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v7.6.26 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.26. |
Description of changes
While working on #9936, I started fixing lint errors which spread to multiple files that were unrelated to overall changes I was making. Separating some of the changes into this PR for review-ability.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.