Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Add support for Email MFA #2935

Merged
merged 20 commits into from
Oct 30, 2024
Merged

feat(auth): Add support for Email MFA #2935

merged 20 commits into from
Oct 30, 2024

Conversation

vincetran
Copy link
Member

@vincetran vincetran commented Oct 7, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: N/A

Description of changes:
The PR aims to add support for Email MFA that has been released by Cognito.
https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pool-settings-advanced-security-email-mfa.html

Draft PR for the Authenticator UI change: aws-amplify/amplify-ui-android#199

How did you test these changes?
Manual testing, new and existing unit tests pass, new and existing integration tests pass

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update) - PR Link Pending

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested a review from a team as a code owner October 8, 2024 05:02
Copy link
Member

@tylerjroach tylerjroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets sync for explanation on how appsync api is being used to test. See additional comments on PR

@tylerjroach tylerjroach merged commit f267334 into main Oct 30, 2024
3 checks passed
@tylerjroach tylerjroach deleted the tjroach/email-mfa branch October 30, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants