Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Remove unused foreground service permission #2877

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Noted that storage plugin was requesting foreground service permission. This is a leftover from Amplify V1 and is unused - there is no Service (or foreground Service) used in Storage V2, we use Work Manager instead.

Listing permissions you don't actually use is bad form, so I've removed it.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner July 23, 2024 13:02
@mattcreaser mattcreaser merged commit 45a2451 into main Jul 23, 2024
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/remove-foreground-service-permission branch July 23, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants