Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Fix the handling of exceptions when subscribing with Kotlin Facade #2821

Merged
merged 2 commits into from
May 16, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
While testing subscription auth modes I found that exceptions during subscription would get replaced with a NPE when using the Kotlin Facade. Resolved the error so that the underlying exception gets propagated to the caller.

How did you test these changes?

  • Unit test
  • Verified issue could not be reproduced after change

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner May 15, 2024 13:47
@mattcreaser mattcreaser force-pushed the mattcreaser/kotlin-facade-subscribe-error branch from 20824aa to af0ea5d Compare May 15, 2024 13:48
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.01%. Comparing base (0f61cc8) to head (81f08a0).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2821      +/-   ##
==========================================
+ Coverage   43.00%   44.01%   +1.00%     
==========================================
  Files         905      925      +20     
  Lines       29179    30220    +1041     
  Branches     4153     4294     +141     
==========================================
+ Hits        12549    13301     +752     
- Misses      15271    15494     +223     
- Partials     1359     1425      +66     

@mattcreaser mattcreaser merged commit 300c6d9 into main May 16, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/kotlin-facade-subscribe-error branch May 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants