-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataStore Model Sync Parallelization #2808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2808 +/- ##
==========================================
+ Coverage 43.00% 44.03% +1.02%
==========================================
Files 905 925 +20
Lines 29179 30245 +1066
Branches 4153 4298 +145
==========================================
+ Hits 12549 13318 +769
- Misses 15271 15500 +229
- Partials 1359 1427 +68 |
lawmicha
reviewed
Jun 6, 2024
aws-datastore/src/main/java/com/amplifyframework/datastore/syncengine/SyncProcessor.java
Outdated
Show resolved
Hide resolved
aws-datastore/src/main/java/com/amplifyframework/datastore/syncengine/SyncProcessor.java
Show resolved
Hide resolved
aws-datastore/src/main/java/com/amplifyframework/datastore/syncengine/SyncProcessor.java
Outdated
Show resolved
Hide resolved
lawmicha
previously approved these changes
Jun 6, 2024
lawmicha
approved these changes
Jun 6, 2024
mattcreaser
approved these changes
Jun 7, 2024
aws-datastore/src/main/java/com/amplifyframework/datastore/DataStoreConfiguration.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to speed up sync times when no associations are present on any models. This is to bring Android into parity with Swift.
Future optimizations could be:
Issue #, if available:
Description of changes:
Comparable Swift Optimization: aws-amplify/amplify-swift#1267
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.