Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Add MFAType.challengeResponse extension #2680

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2677

Description of changes:

  • Add an extension value to MFAType MFAType.TOTP.challengeResponse to get the value to pass to confirmSignIn.
  • If an invalid value is passed to confirmSignIn during MFA selection then return a more descriptive InvalidParameterException.

How did you test these changes?

  • Verified the expected exception is returned when an invalid parameter is passed
  • Verified that using the challengeResponse extension value works as expected.

Documentation update required?

  • No
  • Yes - doc update work is pending

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner January 12, 2024 18:35
ankpshah
ankpshah previously approved these changes Jan 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (861468f) 41.82% compared to head (2e301c5) 41.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
- Coverage   41.82%   41.80%   -0.03%     
==========================================
  Files         902      903       +1     
  Lines       29001    29015      +14     
  Branches     4107     4113       +6     
==========================================
- Hits        12130    12129       -1     
- Misses      15550    15561      +11     
- Partials     1321     1325       +4     

tjleing
tjleing previously approved these changes Jan 12, 2024
@mattcreaser mattcreaser enabled auto-merge (squash) January 15, 2024 15:30
@mattcreaser mattcreaser dismissed stale reviews from tjleing and ankpshah via 4c2b133 January 15, 2024 15:33
@mattcreaser mattcreaser merged commit d028671 into main Jan 16, 2024
6 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/mfa-type-challenge-response branch January 16, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants