Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use returns instead of answers on coEvery #2653

Merged
merged 16 commits into from
Jan 29, 2024

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Dec 13, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tjleing tjleing requested a review from a team as a code owner December 13, 2023 19:00
gpanshu
gpanshu previously approved these changes Dec 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d028671) 41.81% compared to head (27b0ef7) 41.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2653      +/-   ##
==========================================
- Coverage   41.81%   41.80%   -0.02%     
==========================================
  Files         903      903              
  Lines       29015    28887     -128     
  Branches     4113     4113              
==========================================
- Hits        12132    12075      -57     
+ Misses      15559    15488      -71     
  Partials     1324     1324              

@mattcreaser mattcreaser enabled auto-merge (squash) January 29, 2024 14:12
@mattcreaser mattcreaser merged commit e6563dd into main Jan 29, 2024
3 checks passed
@mattcreaser mattcreaser deleted the fix-uncompleted-coroutines-error branch January 29, 2024 23:04
mattcreaser added a commit that referenced this pull request Feb 6, 2024
Co-authored-by: Thomas Leing <[email protected]>
Co-authored-by: gpanshu <[email protected]>
Co-authored-by: Matt Creaser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants