Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push): Add previously removed tests #2589

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Tests were inadvertently removed in previous PR.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner September 15, 2023 21:48
@codecov-commenter
Copy link

Codecov Report

Merging #2589 (8e8c053) into main (3e5e869) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
+ Coverage   41.20%   41.24%   +0.04%     
==========================================
  Files         885      885              
  Lines       28254    28254              
  Branches     3995     3995              
==========================================
+ Hits        11641    11653      +12     
+ Misses      15334    15318      -16     
- Partials     1279     1283       +4     

@mattcreaser mattcreaser merged commit d22b04c into main Oct 6, 2023
8 checks passed
@mattcreaser mattcreaser deleted the tjroach/add-missed-tests branch October 6, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants