feat(Auth): Add TOTP Support (#2537) #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2568 +/- ##
==========================================
- Coverage 41.50% 41.23% -0.27%
==========================================
Files 874 885 +11
Lines 27643 28240 +597
Branches 3883 3993 +110
==========================================
+ Hits 11473 11645 +172
- Misses 14944 15312 +368
- Partials 1226 1283 +57 |
ankpshah
previously approved these changes
Aug 26, 2023
tylerjroach
requested changes
Aug 26, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/KotlinAuthFacadeInternal.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthVerifyTOTPSetupOptions.java
Outdated
Show resolved
Hide resolved
...ain/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthVerifyTOTPSetupOptions.java
Outdated
Show resolved
Hide resolved
...ain/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthVerifyTOTPSetupOptions.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/options/AuthVerifyTOTPSetupOptions.java
Outdated
Show resolved
Hide resolved
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/UserMFAPreference.kt
Outdated
Show resolved
Hide resolved
...java/com/amplifyframework/auth/cognito/exceptions/service/EnableSoftwareTokenMfaException.kt
Outdated
Show resolved
Hide resolved
tylerjroach
requested changes
Aug 27, 2023
...nito/src/androidTest/java/com/amplifyframework/auth/cognito/AWSCognitoAuthPluginTOTPTests.kt
Outdated
Show resolved
Hide resolved
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt
Show resolved
Hide resolved
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt
Show resolved
Hide resolved
| @@ -681,6 +683,53 @@ class AWSCognitoAuthPluginTest { | |||
| verify(timeout = CHANNEL_TIMEOUT) { realPlugin.clearFederationToIdentityPool(any(), any()) } | |||
| } | |||
|
|
|||
| @Test | |||
| fun setUpTOTP() { | |||
There was a problem hiding this comment.
For this test and the 3 tests below it, any() shouldn't be used on the last blocks. Its should be asserting that the correct listeners, etc are passed. In this case it should check expectedOnSuccess and expectedOnError.
tylerjroach
previously approved these changes
Aug 29, 2023
mattcreaser
approved these changes
Aug 29, 2023
tylerjroach
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.