Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme & contributing guide to add versioning #2544

Merged
merged 11 commits into from
Aug 24, 2023
Merged

Conversation

sdhuka
Copy link
Contributor

@sdhuka sdhuka commented Aug 1, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Update readme & contributing guide to add versioning.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sdhuka sdhuka requested a review from a team as a code owner August 1, 2023 18:09
Copy link

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdhuka sdhuka enabled auto-merge (squash) August 1, 2023 18:42
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #2544 (44a33e2) into main (f81521f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2544      +/-   ##
==========================================
+ Coverage   41.44%   41.46%   +0.01%     
==========================================
  Files         874      874              
  Lines       27643    27643              
  Branches     3883     3883              
==========================================
+ Hits        11457    11461       +4     
+ Misses      14959    14955       -4     
  Partials     1227     1227              

@gpanshu gpanshu disabled auto-merge August 24, 2023 17:16
@gpanshu gpanshu enabled auto-merge (squash) August 24, 2023 19:19
@gpanshu gpanshu merged commit aac074a into main Aug 24, 2023
1 check passed
@gpanshu gpanshu deleted the sdhuka-patch-1 branch August 24, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants