Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Auth): Add TOTP Support #2537

Merged
merged 29 commits into from
Aug 21, 2023
Merged

feat(Auth): Add TOTP Support #2537

merged 29 commits into from
Aug 21, 2023

Conversation

sdhuka
Copy link
Contributor

@sdhuka sdhuka commented Jul 27, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Add TOTP Support

How did you test these changes?

  • manually tested various flows
  • Added Unit Test

Documentation update required?

  • No
  • Yes (will updated later)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@gpanshu gpanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@sdhuka sdhuka marked this pull request as ready for review July 28, 2023 16:36
@sdhuka sdhuka requested a review from a team as a code owner July 28, 2023 16:36
@sdhuka sdhuka requested a review from gpanshu July 28, 2023 18:15
@sdhuka sdhuka requested review from gpanshu and a team August 8, 2023 17:01
Copy link
Contributor

@gpanshu gpanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@sdhuka sdhuka requested a review from gpanshu August 9, 2023 15:37
@gpanshu gpanshu mentioned this pull request Aug 11, 2023
6 tasks
@sdhuka sdhuka requested a review from gpanshu August 16, 2023 16:34
@sdhuka sdhuka requested a review from a team August 16, 2023 17:40
@gpanshu gpanshu merged commit 086697a into feature/totp Aug 21, 2023
1 check passed
@gpanshu gpanshu deleted the sdhuka/totp-feature branch August 21, 2023 16:28
gpanshu added a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants