fix(datastore): Fix retry local after a deletion

[mattcreaser]

• PR title and description conform to Pull Request guidelines.

Issue #, if available:

#2261

Description of changes:

If a conflict occurs during a deletion and a retry local strategy is used in the conflict handler then we want to invoke a delete operation. This was previously always doing an update operation, which would result in the deletion being lost.

How did you test these changes?

• Followed these reproduction steps:
  • Configure DataStore with a conflictHandler that always returns a retryLocal() decision.
  • Sync a model to the device
  • Put the device into airplane mode
  • Delete the model on the device
  • In DynamoDB, increase the version number of that model
  • Turn off airplane mode on the device

When the device tries to publish the pending mutation it will result in a conflict because the version numbers do not match. The conflict handler will initiate a retry of the local deletion. The expected behaviour is that this retry will delete the record.

Documentation update required?

• No
• Yes (Please include a PR link for the documentation update)

General Checklist

• Added Unit Tests
• Added Integration Tests
• Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[tylerjroach]

Nice find!

[codecov-commenter]

Codecov Report

Merging #2532 (f690c16) into main (6b30f97) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
+ Coverage   40.63%   40.64%   +0.01%     
==========================================
  Files         873      873              
  Lines       27551    27554       +3     
  Branches     3873     3874       +1     
==========================================
+ Hits        11195    11199       +4     
+ Misses      15156    15155       -1     
  Partials     1200     1200