fix(api): Fix Custom Primary Key API Support #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncorrect for many types
…newly proposed ModelIdentifier codegen changes
|
Reviewers, please take a close look to ensure no unexpected behavior differences from changes made to AppSyncRequestFactory (DataStore) and AppSyncGraphQLRequestFactory (API). |
eeatonaws
reviewed
Jun 28, 2023
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/GraphQLRequestHelper.java
Outdated
Show resolved
Hide resolved
aws-api/src/main/java/com/amplifyframework/api/aws/GraphQLRequestVariable.kt
Show resolved
Hide resolved
aws-api/src/main/java/com/amplifyframework/api/graphql/model/ModelQuery.java
Outdated
Show resolved
Hide resolved
aws-api/src/test/java/com/amplifyframework/api/aws/AppSyncGraphQLRequestAndResponseCPKTest.kt
Outdated
Show resolved
Hide resolved
aws-api/src/test/java/com/amplifyframework/api/aws/AppSyncGraphQLRequestAndResponseCPKTest.kt
Outdated
Show resolved
Hide resolved
aws-api/src/test/java/com/amplifyframework/api/aws/AppSyncGraphQLRequestAndResponseCPKTest.kt
Outdated
Show resolved
Hide resolved
aws-api/src/test/java/com/amplifyframework/api/aws/AppSyncGraphQLRequestFactoryTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/amplifyframework/core/model/ModelIdentifierTest.kt
Show resolved
Hide resolved
testmodels/src/main/java/com/amplifyframework/testmodels/cpk/AmplifyModelProvider.java
Show resolved
Hide resolved
|
@eeatonaws Addressed all comments. Thank you. |
mattcreaser
reviewed
Jun 29, 2023
| try { | ||
| return Collections.singletonMap("not", parsePredicate(qpg.predicates().get(0))); | ||
| } catch (IndexOutOfBoundsException exception) { | ||
| throw new IllegalStateException( |
There was a problem hiding this comment.
Should this be throwing an AmplifyException instead?
There was a problem hiding this comment.
This was a good catch, thank you. API category will now catch this and throw IllegalStateException as before and DataStore will catch and throw DataStoreException as before.
| Map<String, Object> result, | ||
| ModelField modelField, | ||
| Object fieldValue, | ||
| ModelAssociation association) throws AmplifyException { |
There was a problem hiding this comment.
This function doesn't throw AmplifyException
eeatonaws
approved these changes
Jun 29, 2023
mattcreaser
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.