fix(datastore): Release semaphore if an error occurs while starting or stopping the Orchestrator #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengdan154
previously approved these changes
Apr 18, 2023
gpanshu
previously approved these changes
Apr 18, 2023
tjleing
previously approved these changes
Apr 18, 2023
mattcreaser
dismissed stale reviews from tjleing, gpanshu, and dengdan154
via
d0c5f9a
mattcreaser
force-pushed
the
mattcreaser/datastore-start
branch
from
f2c4bc0
to
d0c5f9a
Compare
mattcreaser
force-pushed
the
mattcreaser/datastore-start
branch
from
d0c5f9a
to
346dfa7
Compare
gpanshu
approved these changes
Apr 19, 2023
tylerjroach
approved these changes
Apr 19, 2023
tjleing
approved these changes
Apr 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mattcreaser
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #2263
Description of changes: Add a
doOnErroroperator to release the semaphore if Orchestrator encounters an error during start or stop. This restores the prior behaviour ofdoFinallythat was removed here: https://github.com/aws-amplify/amplify-android/pull/2209/files#diff-eaf24d0ba1fee6a80c5684eccb0f02cdeea76297bf4b41047b2ea9728deb8127L186How did you test these changes? Unit test
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.