Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): Add pagination support for list api #2395

Merged
merged 8 commits into from
Apr 19, 2023
Merged

feat(storage): Add pagination support for list api #2395

merged 8 commits into from
Apr 19, 2023

Conversation

sdhuka
Copy link
Contributor

@sdhuka sdhuka commented Apr 13, 2023 •
edited
Loading

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Deprecate existing list API's
  • Add new list api with pagination support

How did you test these changes?

  • Added integration test
  • Manually tested using pen test app

Documentation update required?

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sdhuka sdhuka requested a review from a team as a code owner April 13, 2023 16:31
@sdhuka sdhuka requested a review from tylerjroach April 18, 2023 16:34
@sdhuka sdhuka requested a review from a team April 19, 2023 13:52
mattcreaser
mattcreaser approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@mattcreaser mattcreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sdhuka sdhuka merged commit e70c3a8 into main Apr 19, 2023
@sdhuka sdhuka deleted the sdhuka/list-api branch April 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcreaser mattcreaser mattcreaser approved these changes

@tylerjroach tylerjroach tylerjroach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdhuka @tylerjroach @mattcreaser