Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(predictions): null check values returned from service #2377

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

eeatonaws
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes: Some values returned from various services used in predictions can be null. Add null checks for these values to prevent errors when transforming them to Amplify types.

How did you test these changes?
Existing unit and integration tests passed (integration test previously failed).

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@eeatonaws eeatonaws requested a review from a team as a code owner March 30, 2023 22:12
@eeatonaws eeatonaws merged commit 2411324 into main Mar 30, 2023
@eeatonaws eeatonaws deleted the null-check-predictions-values branch March 30, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants