Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add granular read ops enum #2265

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented Jan 31, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
aws-amplify/amplify-flutter#2526
Description of changes:
Add granular read operation enums in model auth operation rule
Refer https://docs.amplify.aws/cli/graphql/authorization-rules/#how-it-works

The purpose of adding enum in library is to ensure the model files generated by modelgen will be compiled. However, this is not intended for Datastore usage but for those who use modelgen files along with API plugin. It is not recommended to use them in the datastore due to the prerequisite of sync and listen. This is documented in the callout

How did you test these changes?
(Please add a line here how the changes were tested)

  • Added Unit Tests
  • Added Integration Tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #2265 (3e67d82) into main (07c0de3) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2265      +/-   ##
==========================================
- Coverage   41.43%   41.41%   -0.03%     
==========================================
  Files         874      874              
  Lines       27644    27649       +5     
  Branches     3883     3883              
==========================================
- Hits        11455    11451       -4     
- Misses      14960    14968       +8     
- Partials     1229     1230       +1     

@tylerjroach tylerjroach added datastore DataStore category/plugins feature-request Request a new feature pending-triage Issue is pending triage labels Jan 31, 2023
@tylerjroach tylerjroach requested a review from a team January 31, 2023 15:47
@gpanshu gpanshu enabled auto-merge (squash) August 23, 2023 17:10
@gpanshu gpanshu merged commit 12e66cf into aws-amplify:main Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datastore DataStore category/plugins feature-request Request a new feature pending-triage Issue is pending triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants