fix(datastore): Fix MutationProcessorRetryTest #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r is starting. This caused Datastore.start() to be called earlier than it used to be, which interfered with some tests includuing MutationProcessorRetryTest. Removing the initial publish will keep the behavior closer to the original behavior.
mattcreaser
approved these changes
Feb 1, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2197 +/- ##
============================================
+ Coverage 43.69% 43.74% +0.05%
- Complexity 2585 2589 +4
============================================
Files 744 744
Lines 25060 25059 -1
Branches 2782 2782
============================================
+ Hits 10949 10962 +13
+ Misses 13003 12994 -9
+ Partials 1108 1103 -5 |
eeatonaws
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Removed the initial publish of network status when Reachability Monitor is starting. This caused Datastore.start() to be called earlier than it used to be, which interfered with some tests includuing MutationProcessorRetryTest. Removing the initial publish will keep the behavior closer to the original behavior.
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.