Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Kotlin - Latest release artifact not contains getTransfer method #2190

Closed
1 task done
DenysLoboda opened this issue Dec 21, 2022 · 6 comments
Closed
1 task done
Assignees
Labels
feature-parity Feature missing from this library but available on other ones storage Related to the Storage category/plugins

Comments

@DenysLoboda
Copy link

Before opening, please confirm:

Language and Async Model

Kotlin

Amplify Categories

Storage

Gradle script dependencies

implementation "com.amplifyframework:aws-api:1.37.10"
implementation "com.amplifyframework:aws-auth-cognito:1.37.10"
implementation "com.amplifyframework:aws-storage-s3:1.37.10"

Environment information

------------------------------------------------------------
Gradle 7.6
------------------------------------------------------------

Build time:   2022-11-25 13:35:10 UTC
Revision:     daece9dbc5b79370cc8e4fd6fe4b2cd400e150a8

Kotlin:       1.7.10
Groovy:       3.0.13
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          18.0.2 (Oracle Corporation 18.0.2+9-61)
OS:           Mac OS X 12.6.1 aarch64



Please include any relevant guides or documentation you're referencing

https://docs.amplify.aws/lib/storage/querytransfers/q/platform/android/

Describe the bug

Actually code from repository not contains required method.

Reproduction steps (if applicable)

  1. Add Amplify Storage library to gradle configuration
  2. Sync Project
  3. Check that required method not exist

Code Snippet

Amplify.Storage.getTransfer("TRANSFER_ID",//method not found
    { operation ->
        Log.i("MyAmplifyApp", "Current State" + operation.transferState)
        // set listener to receive updates
        operation.setOnProgress {  }
        operation.setOnSuccess {  }
        operation.setOnError {  }
    },
    {
      error -> Log.e("MyAmplifyApp","Failed to query transfer", error)
    }
)

Log output

// Put your logs below this line


amplifyconfiguration.json

No response

GraphQL Schema

// Put your schema below this line

Additional information and screenshots

No response

@DenysLoboda
Copy link
Author

This method is available in version "2.0.0" however this version does not allow customization of "setAccelerateModeEnabled" which is a critical functionality in my case. Is it possible to use both of these functionalities in any of the versions?

@AnilMaktala AnilMaktala added storage Related to the Storage category/plugins pending-triage Issue is pending triage labels Dec 21, 2022
@sdhuka sdhuka self-assigned this Dec 22, 2022
@sdhuka
Copy link
Contributor

sdhuka commented Jan 6, 2023

@DenysLoboda GetTransfer api is only available in Amplify v2(starting v2.0.0) and won't be added to previous versions.

Could you please share the code snippet for enabling accelerate mode in v1.37.10? I don't see setAccelerateModeEnabled api available in amplify to enable accelerate mode. Once you share the snippet, we will look into supporting it in v2.

@DenysLoboda
Copy link
Author

@sdhuka

            val plugin = Amplify.Storage.getPlugin(PLUGIN_S3) as AWSS3StoragePlugin
            val client = plugin.escapeHatch

            client.setS3ClientOptions(
                S3ClientOptions.builder()
                    .setAccelerateModeEnabled(true)
                    .build()
            )

@sdhuka
Copy link
Contributor

sdhuka commented Jan 10, 2023

Thanks @DenysLoboda, We are currently looking into supporting this in v2.

@sdhuka sdhuka added feature-parity Feature missing from this library but available on other ones and removed pending-triage Issue is pending triage labels Jan 10, 2023
@sdhuka
Copy link
Contributor

sdhuka commented Mar 14, 2023

@DenysLoboda Acceleration mode support is added in v2.3.0, please refer to this documentation for more details.

@sdhuka sdhuka closed this as completed Mar 14, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-parity Feature missing from this library but available on other ones storage Related to the Storage category/plugins
Projects
None yet
Development

No branches or pull requests

3 participants