Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unmasking aws-region in log output #944

Open
2 tasks
shtrom opened this issue Dec 12, 2023 · 3 comments
Open
2 tasks

Allow unmasking aws-region in log output #944

shtrom opened this issue Dec 12, 2023 · 3 comments
Labels
feature-request A feature should be added or improved. p2

Comments

@shtrom
Copy link

shtrom commented Dec 12, 2023

Describe the feature

It would be good for the aws-region not not be masked in the log output of actions. Either by default, or via a configurable option.

Use Case

The aws-region is part of URLs, such as CloudWatch logs. When such a URL is dumped in the logs of a GitHub action, the aws-region value is masked with ***. This makes the URL invalid, and adds friction when deeper investigation by perusal of the log is needed.

Proposed Solution

A similar feature as mask-aws-account-id would be good, to allow unmasking the aws-region in log output when set to

mask-aws-region: no

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@shtrom shtrom added feature-request A feature should be added or improved. needs-triage This issue still needs to be triaged labels Dec 12, 2023
@tim-finnigan
Copy link
Contributor

Thanks for the feature request - this has come up before: #494.

Per that issue:

Got my solution if we don't want your aws region to get masked please don't use it as a secret like {{secrets.AWS_REGION}} simply hard code it in our workflow commands.

Does that solution work for you @shtrom? I saw another issue related to this (#368), but there were issues with reproducing it.

@tim-finnigan tim-finnigan added response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days. and removed needs-triage This issue still needs to be triaged labels Dec 14, 2023
@amlearn
Copy link

amlearn commented Dec 14, 2023

Thanks @tim-finnigan

While we weren't pulling the value from GitHub secrets, we had a similar mechanism to pull values from configuration files and inject them as environment variables.

Some values were masked, but the ones needed visible weren't.

BUT, because masking happens by value, and not by variable, any variable that shares a value or part of a value that has been masked also gets masked.

Thanks for your comment! It inspired a very practical facepalm moment 👍

@amlearn
Copy link

amlearn commented Dec 14, 2023

(I'm a colleague of @shtrom btw - we've now got the visibility of aws-region solved 👍 )

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days. label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants