Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are not being published #531

Closed
sindrig opened this issue Oct 17, 2022 · 4 comments
Closed

Changes are not being published #531

sindrig opened this issue Oct 17, 2022 · 4 comments
Labels
bug Something isn't working effort/medium This issue will take a few days of effort to fix p1

Comments

@sindrig
Copy link

sindrig commented Oct 17, 2022

Describe the bug

After looking at #521 and seeing that @actions/core has already been updated on master, I saw that the package action has been broken for some time. This means that changes to any of the javascript code never make it to dist.

Expected Behavior

Code that reaches master should be packaged automatically

Current Behavior

The package action fails with this error:

 remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: 3 of 3 required status checks are expected. At least 1 approving review is required by reviewers with write access.        
To https://github.com/aws-actions/configure-aws-credentials
 ! [remote rejected] HEAD -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/aws-actions/configure-aws-credentials'
Error: Process completed with exit code 1.

Example run

Reproduction Steps

Not applicable - is broken on master

Possible Solution

No response

Additional Information/Context

No response

@sindrig sindrig added bug Something isn't working needs-triage This issue still needs to be triaged labels Oct 17, 2022
@peterwoodworth
Copy link
Contributor

Thanks for reporting this @sindrig, this occurred when we updated the branch protection rules recently (code has to be merged in a PR and cannot be pushed directly). We're working on figuring out the best permanent solution, but in the meantime we can probably do this manually.

@peterwoodworth peterwoodworth added p1 effort/medium This issue will take a few days of effort to fix and removed needs-triage This issue still needs to be triaged labels Oct 17, 2022
@renperez-cpi
Copy link

@peterwoodworth please update us when this is merged. thank you

@kellertk kellertk mentioned this issue Oct 17, 2022
1 task
@peterwoodworth
Copy link
Contributor

@renperez-cpi The latest changes have been merged to master 🙂

@github-actions
Copy link

⚠️Comment Visibility Warning⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@kellertk kellertk mentioned this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/medium This issue will take a few days of effort to fix p1
Projects
None yet
Development

No branches or pull requests

4 participants