feat: infer role ARN if given role name #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisaurus
reviewed
Mar 4, 2020
| @@ -42,8 +42,16 @@ async function assumeRole(params) { | |||
| accessKeyId, secretAccessKey, sessionToken, region, endpoint, customUserAgent: USER_AGENT | |||
| }); | |||
|
|
|||
| let roleArn = roleToAssume; | |||
| if (!roleArn.startsWith('arn:aws')) { | |||
| const identity = await sts.getCallerIdentity().promise(); | |||
There was a problem hiding this comment.
now there we're potentially calling more than sts:assume-role, would it make sense to include a statement in the Assuming a role section of the README about what permissions this action requires?
There was a problem hiding this comment.
So interesting fact: STS GetCallerIdentity is super fun in that it doesn't require any permissions! And you can't deny the permission to call it!
https://docs.aws.amazon.com/STS/latest/APIReference/API_GetCallerIdentity.html
Regardless, this API actually gets called already lower down after the credentials are retrieved to export the account ID, so that other actions can use it.
allisaurus
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.