-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dockerLabels #274
feat: support dockerLabels #274
Conversation
Signed-off-by: John Seekins <[email protected]>
@sapekshm @iamhopaul123 I see you've recently worked on PRs in this repo. Any chance we could get this change merged? And maybe even a new release cut with this change? |
Hello @johnseekins-pathccm the PR looks good to me. Can you fix failed checks before merging? |
Signed-off-by: John Seekins <[email protected]>
I can't run workflows, but tests are passing locally now. @iamhopaul123 , I think this is ready? |
hello @johnseekins-pathccm looks like the tests are green now. Can you follow the https://conventionalcomments.org/ and fix the title and commit? |
@johnseekins-pathccm ! Can you change your title to |
It's pretty clear that whatever I did didn't follow semantic commits and I don't entirely understand how to fix it. Y'all are welcome to just take the code in a new PR, or if someone wants to tell me exactly how to format the PR to make this work, I'd love some advice. |
@johnseekins-pathccm I don't think rerunning the workflow actually refreshes the values passed into it via the |
Issue #, if available: #272
Description of changes:
Add support for
dockerLabels
in task rendering. Basically updating #138By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.