Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist LEDs #418

Closed
flos06 opened this issue Nov 17, 2022 · 12 comments · Fixed by #419
Closed

Blacklist LEDs #418

flos06 opened this issue Nov 17, 2022 · 12 comments · Fixed by #419
Labels
bug Something isn't working

Comments

@flos06
Copy link

flos06 commented Nov 17, 2022

Feature request

What problem does this feature solve?

The ability to blacklist certain LEDs.
In my case the led strip starts at the middle bottom of the TV. I want to completely ignore (blacklist) the first leds as my tv is on a stand and I don't want the bottom to light up. The leds are actually there so I don't want gaps. I believe hyperion ng has a blacklist feature implemented?
I've tried manually disabling leds by putting these values at 0 for the leds i want to ignore:
{
"group": 0,
"hmax": 0,
"hmin": 0,
"vmax": 0,
"vmin": 0
},

However the Leds still light up.

What does the proposed API look like?

How should this be implemented in your opinion?

Preferably with a UI option, however if it can be done manually I would like some help on how to set it up.

Are you willing to work on this yourself?

I would if I knew how.

@flos06
Copy link
Author

flos06 commented Nov 17, 2022

Just as I typed it I found on the hyperion forum that {
"group": 0,
"hmax": 0,
"hmin": 0,
"vmax": 0,
"vmin": 0
},
doesn't work if using a remote control. I'm using protobuffers. Any other possibilities or is this simply not feasible?

@awawa-dev
Copy link
Owner

Hi
I think you may want to try new context menu from the LED strip geometry designer (v19 beta1). Description: #379
3 Disable/enable selected LED. The LED is still transmitted but its color is set to black. You don't need to manually edit JSON configuration file, just mouse click on the LED you want to disable.

@flos06
Copy link
Author

flos06 commented Nov 18, 2022

So this works however if I use a backlight threshold in image processing the disabled lights still light up.
Any way to have those be disabled when using a backlight threshold?
Thanks for your help :)

@awawa-dev
Copy link
Owner

If I enable backlight threshold I get this error message at the generated LED config:
[0] | should NOT have additional property: disabled
-- | --
  | [1]
  | [2]
  | (64 more errors...)

Could you provide that communicate in more readable form if the problem still occurs?

I will take a look in the post-processing side effect. I haven't take it into account before, but it's quite possible that post-processing overrides the black LEDs. Need to be fixed.

@flos06
Copy link
Author

flos06 commented Nov 18, 2022

I've attached a screenshot. However it appears that the led config ui doesn't like disabled leds at all. It doesn't matter if backlight is on or not it spits out the error anyways.
"but it's quite possible that post-processing overrides the black LEDs." This would be my guess as to the issue.
leds

@awawa-dev
Copy link
Owner

Thanks. I'll keep you updated. These things need to be fixed before v19 stable release.

@awawa-dev awawa-dev added bug Something isn't working and removed feature request labels Nov 18, 2022
@awawa-dev
Copy link
Owner

I think I fixed it. The installer will be ready to download when finished:
https://github.com/awawa-dev/HyperHDR/actions/runs/3499994403

@flos06
Copy link
Author

flos06 commented Nov 18, 2022

Thanks for the quick update.
I can confirm that the errors no longer appear and that the LEDs stay deactivated with backlight threshold on.
However I have one more issue of which I am unsure if its doable.
For my own media I use hyperion as ambilight. However as we all know this does not work with DRM. So if I watch for example Netflix I have home assistant send the color white to hyperion which gives me some nice bias lighting instead. The disabled LEDs still light up using this.
Do you have any ideas on how to make
remote control
the disabled leds stay disabled?
home assistance leds

@flos06
Copy link
Author

flos06 commented Nov 18, 2022

The same happens with colors/effects
colors

So basically what I'm asking is if it is also possible to ignore LEDs when using a color

@awawa-dev
Copy link
Owner

awawa-dev commented Nov 18, 2022

Yes, colors are using different path than images (usb grabber/flatbuffers/protobuffers).
Try this:
https://github.com/awawa-dev/HyperHDR/actions/runs/3501002337

Just one small thing: colors are not live updated so when you are designing LED strip geometry and disable/enable some LEDs you need to apply color again to have it visible in the preview/LED output. It's only design time limitation.

@awawa-dev
Copy link
Owner

awawa-dev commented Nov 19, 2022

I've found another "back-door" that allowed colors for disabled leds: effects that use direct LED rendering like "Breath". So decided to fix it in another way, in a place where all these paths come together. Hope it's a final solution.
https://github.com/awawa-dev/HyperHDR/actions/runs/3503207669

@flos06
Copy link
Author

flos06 commented Nov 19, 2022

Thanks I can confirm this solved everything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants